博客 Engineering

Aligning Passman's Tab Borders With Nextcloud Theme Colors

英文文章. Passman's settings and edit tabs used hardcoded border colors. The merged change switches them to Nextcloud's theme variables.

JavaScriptCSSnextcloud/passmanthemingaccessibility

A small theming change, merged with a candid note from the maintainer.

简短回答

Passman's tab containers used hardcoded border colors and an inline theme override. This change switches them to Nextcloud's CSS variables, --color-border and --color-primary-element, and removes the inline override from the settings and edit-credential views. It was merged as PR #874, which referenced issue #409.

The problem

Passman is a password manager app for Nextcloud. Issue #409, from 2017, reported that with a white Nextcloud theme the settings tab titles and boxes were hard to see.

The change

 .tab_container {
-  border: 1px solid #eee;
-  border-top-color: #0082c9;
+  border: 1px solid var(--color-border);
+  border-top-color: var(--color-primary-element);
-    <div class="tab_container edit_credential" use-theme type="'border-top-color'">
+    <div class="tab_container edit_credential">

The same change was mirrored in the compiled css/app.css and js/templates.js.

By the numbers

  • Repository: nextcloud/passman, 829 stars (Nov 3, 2026), JavaScript, AGPL-3.0
  • Files changed: 5
  • Lines: +8 / -8
  • Commits: 1
  • Opened: Aug 21, 2026. Merged: Aug 24, 2026. Time to merge: 3 days, 1 hour
  • Review: approved and merged by a maintainer

How the review went

The maintainer approved it with an honest assessment: "Well, thanks for the pr. It does not fix the mentioned issue, but it indeed fixes the Nextcloud color alignment."

常见问题解答

So did it fix issue #409?

According to the maintainer, no. The merged value is consistent theming with Nextcloud's own color variables.

Where can I read more?

See the pull request and the referenced issue.

目标

Not every merged PR does what it set out to do. This one still left the app more consistent with its host platform, and the maintainer said exactly that.

运行闭环

把生产信号转化为已审查的修复。

开始免费试用,了解 Prilog 如何把真实事故映射到代码级 Pull Request。